New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that generated compat-data is up to date on CI #11024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
Jan 16, 2020
JLHwung
approved these changes
Jan 16, 2020
JLHwung
added
the
PR: Internal 🏠
A type of pull request used for our changelog categories
label
Jan 16, 2020
JLHwung
reviewed
Jan 16, 2020
@@ -306,7 +306,7 @@ const generateData = (environments, features) => { | |||
"The newly generated plugin/built-in data does not match the current " + | |||
"files. Re-run `make build-compat-data`." | |||
); | |||
process.exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert this commit? I realize that this function is in a forEach
callback.
nicolo-ribaudo
force-pushed
the
check-compat-data
branch
from
January 16, 2020 23:40
7aeda7a
to
8339bad
Compare
JLHwung
approved these changes
Jan 17, 2020
nicolo-ribaudo
force-pushed
the
check-compat-data
branch
from
January 20, 2020 00:05
8339bad
to
79466ef
Compare
This was referenced Feb 24, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 25, 2020
This was referenced Apr 2, 2020
This was referenced Apr 9, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: tests
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent cases like 6363b59: the file used to generate the data was updated but the data itself wasn't, so we didn't notice the regression in the PR which updated the compat-table mappings.